[Website] Allow users to set Playground name before saving and rename saved Playgrounds #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@akirk, I'm ping you here to let you know Bero asked me to take care of this. I will take a look at what is happening on these E2Es once I will finish my other tasks. |
Collaborator
|
The test failures here are weird. I've started #2486 to work with a smaller change for easier reviews and debugging. |
adamziel
added a commit
that referenced
this pull request
Aug 31, 2025
## Motivation for the change, related issues A limited version of #2124 that only enables renaming stored Playgrounds. It does not enforce choosing a name when the Playground is first saved – it reduces the size of the PR and makes testing and reviewing easier (the original PR is larger and breaks the E2E tests). ## Testing Instructions (or ideally a Blueprint) This PR ships an E2E test. For manual testing: - Checkout this branch - Start the dev server npm run dev - Go to the Playground manager - Click save on a temporary site - Click on the kebab menu of that site and click Rename - Rename the site and confirm the changes are saved - Refresh the page and confirm the new name is still there
Collaborator
Author
|
Playground renaming was implemented in #2486, so we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Before this PR when saving a Playground a name was automatically generated, but there was no way to change the name.
This PR adds the ability to set the Playground name before saving it and rename the Playground after it's already saved.
Note Some of the PR changes were auto-generated linter changes.
Testing Instructions (or ideally a Blueprint)
npm run dev